Remove GWInterfaceBase
, GWInterface
, and co.
#9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GWInterfaceBase
,GWInterface
, and co, were useless abstractions of encoders and decoders.Now,
GWModule
additionaly takes thedomain_mods
as parameter.Moreover, instead of requiring
gw_intefaces
it now needs to mapping:gw_encoders
andgw_decoders
which aretorch.nn.Module
s that encode or decode the unimodal representation to and from the GW representation.See updated
docs/shimmer_basics.md
and examples to see how to update existing code.